Fix context usage in shim package #3224
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2025
r4victor
reviewed
Oct 27, 2025
Collaborator
r4victor
left a comment
r4victor
left a comment
There was a problem hiding this comment.
Cancelling some operations like "umount" can be problematic. Not sure it's an improvement.
Signed-off-by: Matías Insaurralde <[email protected]>
matiasinsaurralde
force-pushed
the
internal-shim-fixes
branch
from
d3b0e0a to
15d30a9
Compare
Prevents umount command cancellation which could lead to data corruption and filesystem inconsistencies. Addresses review feedback about cancelling critical filesystem operations. Signed-off-by: Matías Insaurralde <[email protected]>
Contributor
Author
Makes sense - I've refactored the PR a bit, still passing context to exec.CommandContext(context.TODO(), "umount", "-qf", mountPoint)I've inspected the other operations (there should be no impact if cancelled, they return errors and/or can be retried):
|
r4victor
reviewed
Oct 28, 2025
| continue | ||
| } | ||
| cmd = exec.Command("umount", "-qf", mountPoint) | ||
| cmd = exec.CommandContext(context.TODO(), "umount", "-qf", mountPoint) |
Collaborator
There was a problem hiding this comment.
So what's the benefit of CommandContext(context.TODO()?
|
This PR is stale because it has been open for 14 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #3223 but for the shim package.
Had to update the
Backendinterface to take the context 👍